Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Bump main to 7.0.0~pre1 #189

Merged
merged 2 commits into from
Aug 8, 2022
Merged

⬆️ Bump main to 7.0.0~pre1 #189

merged 2 commits into from
Aug 8, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina
⬆️ Bump main to 7.0.0~pre1
ad5b055 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from nkoenig as a code owner August 5, 2022 18:34
@chapulina chapulina mentioned this pull request Aug 5, 2022
Open
@codecov
Copy link

codecov bot commented Aug 5, 2022 •
edited
Loading

Codecov Report

Merging #189 (072165e) into main (178645f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   56.90%   56.90%           
=======================================
  Files           3        3           
  Lines         413      413           
=======================================
  Hits          235      235           
  Misses        178      178

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chapulina
changelog
072165e 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina enabled auto-merge (squash) August 8, 2022 16:32
jennuine
jennuine reviewed Aug 8, 2022
View reviewed changes
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about *launch6* in https://github.com/gazebosim/gz-launch/blob/main/src/cmd/CMakeLists.txt ?

@chapulina
Copy link
Contributor Author

How about launch6 in https://github.com/gazebosim/gz-launch/blob/main/src/cmd/CMakeLists.txt ?

Those are comments in examples, so I think either way they're ok

@chapulina chapulina merged commit a724067 into main Aug 8, 2022
@chapulina chapulina deleted the chapulina/7/bump branch August 8, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine jennuine approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @jennuine